Skip to content

fix compilation issue - #4613

Merged
nlohmann merged 3 commits into
nlohmann:developfrom
hnampally:issue-4019
Jan 22, 2025
Merged

fix compilation issue#4613
nlohmann merged 3 commits into
nlohmann:developfrom
hnampally:issue-4019

Conversation

@hnampally

@hnampally hnampally commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

#4019

  • The changes are described in detail, both the what and why.
  • If applicable, an existing issue is referenced.
  • The Code coverage remained at 100%. A test case for every new line of code.
  • If applicable, the documentation is updated.
  • The source code is amalgamated by running make amalgamate.

Read the Contribution Guidelines for detailed information.

@hnampally
fix compilation issue
d055473 
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@hnampally
hnampally requested a review from nlohmann as a code owner January 20, 2025 06:33
@coveralls

coveralls commented Jan 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 99.186%. remained the same
when pulling 3677d24 on hnampally:issue-4019
into bd4fea3 on nlohmann:develop.

@hnampally
add unit test
b68bd16 
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
hnampally
hnampally commented Jan 20, 2025
View reviewed changes
Comment thread include/nlohmann/detail/json_pointer.hpp Outdated
@hnampally
fix ci failure check
3677d24 
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@github-actions

github-actions Bot commented Jan 22, 2025

Copy link
Copy Markdown

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @hnampally
Please read and follow the Contribution Guidelines.

nlohmann
nlohmann approved these changes Jan 22, 2025
View reviewed changes

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann linked an issue Jan 22, 2025 that may be closed by this pull request
flatten() function does not compile if an alternative string type is used #4019
Closed
1 of 2 tasks
@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 22, 2025
@nlohmann
nlohmann merged commit bf8ccc2 into nlohmann:develop Jan 22, 2025
@nlohmann

nlohmann commented Jan 22, 2025

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlohmann nlohmann nlohmann approved these changes
+1 more reviewer
@gregmarr gregmarr gregmarr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

M tests

Projects

None yet

Milestone

Release 3.12.0

Development

Successfully merging this pull request may close these issues.

flatten() function does not compile if an alternative string type is used

4 participants

@hnampally @coveralls @nlohmann @gregmarr