Repository navigation
Add clang-tools to required tools for ci_static_analysis_clang - #3724
Merged
Merged
Conversation
Contributor
|
You can cancel my workflows since they're going to fail anyway. |
falbrechtskirchinger
suggested changes
Sep 11, 2022
falbrechtskirchinger
left a comment
falbrechtskirchinger
left a comment
Contributor
There was a problem hiding this comment.
I expected more cases where NOLINT might be needed.
I don't understand why variables that curiously always seem to appear in CHECK(var == ...) and can clearly be const are not being complained about.
Comment on lines
+23
to
+24
| json const j(json::value_t::null); | ||
| json::const_iterator const it(&j); |
Contributor
There was a problem hiding this comment.
This seems fine but is another one of those corner cases we should pay attention to in this PR.
falbrechtskirchinger
approved these changes
Sep 13, 2022
falbrechtskirchinger
left a comment
falbrechtskirchinger
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build, see #3723 (comment)