Repository navigation
Conversation
nlohmann
marked this pull request as draft
July 21, 2021 12:04
nlohmann
marked this pull request as ready for review
July 21, 2021 17:44
harry75369
pushed a commit
to harry75369/json
that referenced
this pull request
Aug 8, 2021
* ♻️ split Unicode tests
nlohmann
added a commit
that referenced
this pull request
Sep 27, 2026
The Unicode tests were split into five files (#2889) so they could run in parallel. After #5418 they take ~20 s together (unoptimized), so one file is enough. This removes four copies of the check helpers and the progress output, whose hard-coded totals were stale, and drops doctest::skip() so JSON_FastTests configurations run them too. The raised timeout for test-unicode4 is no longer needed. Signed-off-by: Niels Lohmann <mail@nlohmann.me>
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the large Unicode test suite into 5 smaller ones to allow for parallel execution. Furthermore, some static variables reduce the number of required allocations.