compiler warning: double definition of macro JSON_INTERNAL_CATCH  #1213

Activity

1. nlohmann commented on Aug 24, 2018

   

   nlohmann

   on Aug 24, 2018

   Owner

   More actions

   This was introduced by #1187.

   @simnalamburt Could you have a look at this please?
2. nlohmann

   added

   kind: bug

   confirmed

   on Aug 24, 2018
3. nlohmann commented on Aug 24, 2018

   

   nlohmann

   on Aug 24, 2018

   Owner

   More actions

   I can confirm the warning. Minimal compilable program:

   #define JSON_TRY_USER if(true)
   #define JSON_CATCH_USER(exception) if(false)
   #include "single_include/nlohmann/json.hpp"
   
   int main()
   {}
4. simnalamburt commented on Aug 24, 2018

   

   simnalamburt

   on Aug 24, 2018

   Contributor

   More actions

   Oops I catched the mistake. I'll send a follow-up PR

   👍React with 👍1Reacted by Niels Lohmann
5. simnalamburt

   added a commit that references this issue on Aug 24, 2018

   Fix nlohmann#1213

   This issue will close once commit aada309 is merged into the 'develop' branch.

   aada309
6. nlohmann

   closed this as completedin #1214on Aug 24, 2018
7. nlohmann

   added a commit that references this issue on Aug 24, 2018

   Merge pull request #1214 from devsisters/fix-1213

   ...

   This issue will close once commit 04597c3 is merged into the 'develop' branch.

   04597c3
8. nlohmann

   added this to the Release 3.2.1 milestone on Aug 24, 2018
9. nlohmann

   added

   solution: proposed fixa fix for the issue has been proposed and waits for confirmationa fix for the issue has been proposed and waits for confirmation

   on Aug 24, 2018
10. nlohmann

    self-assigned this

    on Aug 24, 2018