fix(vercel, azure): serve prerendered routes statically - #500
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 63.62% 63.48% -0.15%
==========================================
Files 55 55
Lines 3634 3620 -14
Branches 394 392 -2
==========================================
- Hits 2312 2298 -14
+ Misses 1309 1308 -1
- Partials 13 14 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pi0
reviewed
Sep 14, 2022
pi0
reviewed
Sep 14, 2022
pi0
approved these changes
Sep 14, 2022
WinterYukky
pushed a commit
to WinterYukky/nitro
that referenced
this pull request
Nov 1, 2022
Co-authored-by: Pooya Parsa <pooya@pi0.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Current hybrid vercel deployments will always server-render prerendered HTML (though you can get the static html by adding
/index.htmlto the URL). Vercel provides theoverridesproperty to allow us to map clean URLs (without.htmlorindex.htmlsuffix) to static files: https://vercel.com/docs/build-output-api/v3#build-output-configuration/supported-properties/overrides. This PR implements that.Might also be worth a consistent implementation of accessing which HTML files have been prerendered. (See this line for how we were doing it in Azure - I could easily create a shared context that both presets could use - happy to pick this up.)
📝 Checklist