Fix browser build sync and alive behavior#374
Merged
MikePlante1 merged 2 commits intonightscout:devfrom Aug 16, 2024
Merged
Conversation
… LoopWorkspace PR 164
Contributor
Author
|
In addition to the files listed above, comparison was also made between LoopWorkspace 3.4.1 for these files:
The first two files are identical. The Fastfile has the suitable changes between Loop and Trio along with some whitespace changes. The Trio version configures and uses the BUNDLE_ID which simplifies some lines. |
bjornoleh
reviewed
Aug 4, 2024
bjornoleh
reviewed
Aug 4, 2024
dnzxy
approved these changes
Aug 14, 2024
Contributor
Author
StatusSuccess TestingThis can be tested now that there is a
Test Overview:
Test dev branch with PR 374 applied
Test main branch
|
MikePlante1
approved these changes
Aug 15, 2024
Contributor
MikePlante1
left a comment
There was a problem hiding this comment.
Pulled this PR in and successfully built, which correctly created two new branches: alive-main and alive-dev.
MikePlante1
reviewed
Aug 15, 2024
Merged
mountrcg
referenced
this pull request
in mountrcg/Tai
Sep 11, 2024
Fix browser build sync and alive behavior
EJM0
pushed a commit
to EJM0/Trio
that referenced
this pull request
Dec 10, 2025
* Minutes ago fix for G7 sensors. * Fix compile issue in Xcode 14 (nightscout#235) * Improve the update of the date of Glucose View Header. * Allow looping when HIGH (nightscout#259) - Allow lflat glucose when CGM readings are HIGH (but disable SM and high temps) for IOB computations etc. - Display HIGH when CGM reading is HIGH. - Display real glucose when entering capillary glucose. - Allow (capillary readings over HIGH for normal looping. - Display in Enacted pop-up. - Display warning in same pop-up - Disable SMB and high temps in oref2 code when reading is HIGH (potential invalid CGM reading). * Add Dexcom G7 SAGE.Upload activation and session start date to NS. * Fix run script for branch name and commit ID to work with Xcode 15 (nightscout#274) * BuildBranch fix for Xcode 15 * Display build number like TestFlight (build number in brackets) * Hard limit of 55 for insulinPeakTime to avoid endless logs and errors in oref0 * Prevent Nightscout collisions from occurring due to non-unique glucose-IDs IDs Fix for all CGMs. * Check for a trailing slash (/) at the end of the URL entered by the user and remove it to prevent 404's --------- Co-authored-by: Pierre L <pn.lagarde@gmail.com> Co-authored-by: bjornoleh <63544115+bjornoleh@users.noreply.github.com> Co-authored-by: Liroy van Hoewijk <4643445+LiroyvH@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in response to Trio Issue #373. In addition to fixing the main build for GitHub actions, this also brings in these other changes:
# Patch Fastlane Match to not print tablesto not print user information in the clearThis PR uses changes to LoopWorkspace PR 164 following release of Loop version 3.4.0.
The timing is such that the main branch must exist and this PR be applied at the same time.
Status:
Test
Code Review:
I compared the *.yml files found in LoopWorkspace (main, aka 3.4.1)
These 3 are identical:
These files differ only in references to LoopWorkspace vs Trio and LoopWorkspace embeds a section on customizations that it not found in Trio: