Skip to content

Increase height of Compact Tab and Profile/TT row - #137

Merged
MilosKozak merged 3 commits into
nightscout:devfrom
Philoul:IncreaseHeightUpperRows
Dec 26, 2020
Merged

Increase height of Compact Tab and Profile/TT row#137
MilosKozak merged 3 commits into
nightscout:devfrom
Philoul:IncreaseHeightUpperRows

Conversation

@Philoul

@Philoul Philoul commented Dec 24, 2020

Copy link
Copy Markdown
Contributor

Some users have difficulties in Compact mode to select the 3 dots or hamburger menus due to height too small.
=> I propose to use same Height for Compact tabs than Standard tabs
=> I increased a little bit height of Profile / Target buttons for the same reason

@osodebailar

osodebailar commented Dec 24, 2020

Copy link
Copy Markdown
Contributor

Do you have 2 pictures with before and after ?

@codecov

codecov Bot commented Dec 24, 2020

Copy link
Copy Markdown

Codecov Report

Merging #137 (363fe63) into dev (3c32583) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #137      +/-   ##
============================================
- Coverage     10.26%   10.23%   -0.03%     
  Complexity     1131     1131              
============================================
  Files           758      758              
  Lines         35315    35315              
  Branches       5153     5153              
============================================
- Hits           3625     3616       -9     
- Misses        31408    31421      +13     
+ Partials        282      278       -4     
Impacted Files Coverage Δ Complexity Δ
.../info/nightscout/androidaps/queue/QueueThread.java 11.70% <0.00%> (-9.58%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c32583...363fe63. Read the comment docs.

@Philoul

Philoul commented Dec 24, 2020

Copy link
Copy Markdown
Contributor Author

See screenshots below (in french)
Screenshot_20201224-115432_AndroidAPS

@Philoul

Philoul commented Dec 24, 2020

Copy link
Copy Markdown
Contributor Author

If the height increase is too much for compact tabs, I can just increase the default compact height a bit (currently 30dp, something between 40dp and 48dp might be a good compromise)

@osodebailar

Copy link
Copy Markdown
Contributor

I think it's a good solution .
It's nearly the same as I did in my bottom toolbar in my GUI fork. And as I know all users are very satisfied with the size .

I would prefer your solution .

@MilosKozak

Copy link
Copy Markdown
Contributor

how does it look like with short names used?

@Philoul

Philoul commented Dec 25, 2020

Copy link
Copy Markdown
Contributor Author

In my first proposal, Heigth of Compact menu was the same than Standard menu (but I think it's too important), so I made a second commit to increase a little bit Compact height (see in screenshot below on the left current heights, in the middle first version and on the right with latest commit.
Screenshot_20201225-164639_AndroidAPS

@AdrianLxM

Copy link
Copy Markdown
Contributor

Up until Android 9 I'd have said: For the compact one I'd go with the first.

Now with swipe gestures to go back on newer Android versions people might actually want to press the burger button. As the gesture to open the drawer and "back" conflicts.

@MilosKozak
MilosKozak merged commit 4705dee into nightscout:dev Dec 26, 2020
@Philoul
Philoul deleted the IncreaseHeightUpperRows branch December 27, 2020 21:56
MilosKozak pushed a commit that referenced this pull request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants