Increase height of Compact Tab and Profile/TT row - #137
Conversation
|
Do you have 2 pictures with before and after ? |
Codecov Report
@@ Coverage Diff @@
## dev #137 +/- ##
============================================
- Coverage 10.26% 10.23% -0.03%
Complexity 1131 1131
============================================
Files 758 758
Lines 35315 35315
Branches 5153 5153
============================================
- Hits 3625 3616 -9
- Misses 31408 31421 +13
+ Partials 282 278 -4
Continue to review full report at Codecov.
|
|
If the height increase is too much for compact tabs, I can just increase the default compact height a bit (currently 30dp, something between 40dp and 48dp might be a good compromise) |
|
I think it's a good solution . I would prefer your solution . |
|
how does it look like with short names used? |
|
Up until Android 9 I'd have said: For the compact one I'd go with the first. Now with swipe gestures to go back on newer Android versions people might actually want to press the burger button. As the gesture to open the drawer and "back" conflicts. |


Some users have difficulties in Compact mode to select the 3 dots or hamburger menus due to height too small.
=> I propose to use same Height for Compact tabs than Standard tabs
=> I increased a little bit height of Profile / Target buttons for the same reason