Fix init experiment & create Tests app#183
Merged
lalitkumarj merged 4 commits intomasterfrom Jul 22, 2017
Merged
Conversation
Member
|
LGTM, and 👍 to the test app. |
|
@lalitkumarj is there any reason this PR hasn't been merged yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes #160 by initializing the butler.experiments collection as a document containing only the
exp_uidbefore callingmyApp.initExp.The problem before was that if someone called
butler.experiment.set(key='foo', value='bar')inmyApp.initExp, it would initialize the experiment collection as a document which didn't have theexp_uidin it which would create all kinds of hard-to-debug errors down the road.In this commit, I've also created a
Testsapp, which is a minimal app for us to write integrated tests for all kinds of stuff (testing the database API, for example). For example, I wrote a test that demonstrates that you can now set an arbitrary key usingbutler.experiments.setinmyApp.initExp.I've run all tests locally (including new ones) with no errors.