Skip to content

Fix init experiment & create Tests app#183

Merged
lalitkumarj merged 4 commits intomasterfrom
fix_init_experiment
Jul 22, 2017
Merged

Fix init experiment & create Tests app#183
lalitkumarj merged 4 commits intomasterfrom
fix_init_experiment

Conversation

@dconathan
Copy link
Copy Markdown
Contributor

This commit fixes #160 by initializing the butler.experiments collection as a document containing only the exp_uid before calling myApp.initExp.

The problem before was that if someone called butler.experiment.set(key='foo', value='bar') in myApp.initExp, it would initialize the experiment collection as a document which didn't have the exp_uid in it which would create all kinds of hard-to-debug errors down the road.

In this commit, I've also created a Tests app, which is a minimal app for us to write integrated tests for all kinds of stuff (testing the database API, for example). For example, I wrote a test that demonstrates that you can now set an arbitrary key using butler.experiments.set in myApp.initExp.

I've run all tests locally (including new ones) with no errors.

@dconathan dconathan requested a review from lalitkumarj April 24, 2017 02:14
@stsievert
Copy link
Copy Markdown
Member

LGTM, and 👍 to the test app.

@erinzm
Copy link
Copy Markdown

erinzm commented Jul 17, 2017

@lalitkumarj is there any reason this PR hasn't been merged yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change how experiment document is initialized

4 participants