Fix setFullScreenMode on talk viewer opening#1331
Conversation
|
/backport to stable24 |
|
/rebase |
cffe295 to
88814c7
Compare
|
/compile amend / |
88814c7 to
37baf15
Compare
danxuliu
left a comment
There was a problem hiding this comment.
Do you have reproduction steps? I have never seen that error (and I also tried to reproduce it without success), and it should not happen, as the fake sidebar has a setFullScreenMode function.
If the issue is caused by Talk I think it would be better to fix it in Talk instead (if it is possible, which I do not know :-) ).
|
Maybe I was too much behind lol |
danxuliu
left a comment
There was a problem hiding this comment.
Maybe I was too much behind lol
More than a year, it is surprising that Talk even loaded :-O
In any case, this is good sanity check ;)
Then typeof OCA?.Files?.Sidebar?.setFullScreenMode === 'function'? Or that is too much? :-P
Anyway, fine by me to keep the old code, to check if setFullScreenMode exists or to check if setFullScreenMode is a function 👍
37baf15 to
60c475e
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
60c475e to
2732f1b
Compare
|
The backport to stable24 failed. Please do this backport manually. |
Because Talk is doing some shenanigans to fake the Files Sidebar