Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
/backport to stable18 |
|
/compile /js |
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
Icon changed
I wondered if we should create some dedicated functions in a library so it's easier to use? I feel like just using css rules that are duplicate seems a bit weird 🤔 |
|
Yep, that is fixed in a separate PR. I think we could even drop that test as for text it should be fine to assume that the viewer does its stuff properly, however I added a case for it back then since we were the only app integrating at that point in time. |
|
The backport to stable18 failed. Please do this backport manually. |
|
/backport 35b2f07 to stable18 |
|
backport to stable18 in #783 with conflicts |
|
/backport 69e0eca to stable18 |
|
The backport to stable18 failed. Please do this backport manually. |
|
/backport 69e0eca to stable18 |
|
backport to stable18 in #784 with conflicts |
The files app does no longer support javascript based preview plugins since Nextcloud 18