Conversation
Member
|
LGTM; Is it possible to have tests for it? |
mejo-
reviewed
Sep 29, 2022
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks for looking into it @luka-nextcloud! I agree with @vinicius73 that we should have tests for that.
lib/Controller/UserApiController.php
Outdated
| use OCP\IUserManager; | ||
| use OCP\IUserSession; | ||
| use OCP\Share\IShare; | ||
| use Psr\Log\LoggerInterface; |
Member
There was a problem hiding this comment.
Sorry, just realized that you fixed it in a follow-up commit.
luka-nextcloud
force-pushed
the
bug/mention-search-issues
branch
from
3a81d1c to
2209f6f
Compare
Member
|
/backport to stable25 |
mejo-
approved these changes
Oct 4, 2022
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks a lot @luka-nextcloud, works as expected now ❤️
mejo-
requested changes
Oct 4, 2022
Member
|
@luka-nextcloud also, please fix the code style issues reported by php-cs-fixer (see PHP linting CI job). |
luka-nextcloud
force-pushed
the
bug/mention-search-issues
branch
from
b095bcb to
96f515a
Compare
Contributor
Author
|
@mejo- Please check again :) |
mejo-
force-pushed
the
bug/mention-search-issues
branch
from
96f515a to
e8e3d15
Compare
mejo-
reviewed
Oct 10, 2022
mejo-
force-pushed
the
bug/mention-search-issues
branch
4 times, most recently
from
e2a01b4 to
934ff3a
Compare
mejo-
approved these changes
Oct 10, 2022
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
bug/mention-search-issues
branch
from
934ff3a to
609719e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary