Merged
Conversation
Unscoped auth is not guaranteed to return a catalog. So require the scope to be set properly. See https://developer.openstack.org/api-ref/identity/v3/index.html#password-authentication-with-unscoped-authorization Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@
## master #9280 +/- ##
============================================
- Coverage 51.95% 51.94% -0.01%
- Complexity 25382 25383 +1
============================================
Files 1608 1608
Lines 95413 95423 +10
Branches 1394 1394
============================================
Hits 49571 49571
- Misses 45842 45852 +10
|
Member
|
This will also need to be added to the external storage configuration then |
Member
Author
|
@icewind1991 fine. But lets do that in a separate pr ;) |
Member
|
As long as we actually remember to make that follow up and not have a broken swift external storage. |
icewind1991
approved these changes
Apr 24, 2018
Contributor
#11264 🤔 |
Contributor
Member
|
@icewind1991 mind to look into this again? |
backportbot-nextcloud bot
pushed a commit
to nextcloud/documentation
that referenced
this pull request
Apr 21, 2020
Add an example of Swift V3 with a configuration scope following this commit : nextcloud/server#9280
MorrisJobke
pushed a commit
to nextcloud/documentation
that referenced
this pull request
Apr 21, 2020
Add an example of Swift V3 with a configuration scope following this commit : nextcloud/server#9280
backportbot-nextcloud bot
pushed a commit
to nextcloud/documentation
that referenced
this pull request
Apr 21, 2020
Add an example of Swift V3 with a configuration scope following this commit : nextcloud/server#9280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unscoped auth is not guaranteed to return a catalog. So require the
scope to be set properly.
See https://developer.openstack.org/api-ref/identity/v3/index.html#password-authentication-with-unscoped-authorization
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl