Skip to content

Remove deprecated and unused OCP\Response#8918

Merged
MorrisJobke merged 1 commit intomasterfrom
remove-deprecated-ocp-response
Mar 21, 2018
Merged

Remove deprecated and unused OCP\Response#8918
MorrisJobke merged 1 commit intomasterfrom
remove-deprecated-ocp-response

Conversation

@MorrisJobke
Copy link
Copy Markdown
Member

Ref #7827

Copy link
Copy Markdown
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Copy Markdown
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the remove-deprecated-ocp-response branch from db45340 to d435061 Compare March 21, 2018 15:54
@MorrisJobke
Copy link
Copy Markdown
Member Author

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

Fixed -> merging.

@MorrisJobke MorrisJobke merged commit de32978 into master Mar 21, 2018
@MorrisJobke MorrisJobke deleted the remove-deprecated-ocp-response branch March 21, 2018 15:54
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2018

Codecov Report

Merging #8918 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #8918      +/-   ##
============================================
- Coverage     51.96%   51.89%   -0.07%     
+ Complexity    25277    25276       -1     
============================================
  Files          1604     1603       -1     
  Lines         94881    94794      -87     
  Branches       1388     1377      -11     
============================================
- Hits          49306    49198     -108     
- Misses        45575    45596      +21
Impacted Files Coverage Δ Complexity Δ
apps/files_versions/download.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/js/sharedialogview.js 75.43% <0%> (-12.11%) 0% <0%> (ø)
lib/public/User.php 37.5% <0%> (-5.36%) 8% <0%> (+1%)
lib/private/Files/ObjectStore/SwiftFactory.php 51% <0%> (-4%) 37% <0%> (ø)
core/js/sharedialogshareelistview.js 47.73% <0%> (-1.05%) 0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.46% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants