Skip to content

Move storagestats endpoint to proper controller#8800

Merged
MorrisJobke merged 1 commit intomasterfrom
getstoragestats_to_controller
Mar 13, 2018
Merged

Move storagestats endpoint to proper controller#8800
MorrisJobke merged 1 commit intomasterfrom
getstoragestats_to_controller

Conversation

@rullzer
Copy link
Copy Markdown
Member

@rullzer rullzer commented Mar 13, 2018

For #8568

@rullzer rullzer added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Mar 13, 2018
@rullzer rullzer added this to the Nextcloud 14 milestone Mar 13, 2018
public function getStorageStats(string $dir = '/'): JSONResponse {
try {
return new JSONResponse([
'status' => 'succes',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

success?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the getstoragestats_to_controller branch from 6a2bbe5 to f52ba44 Compare March 13, 2018 11:44
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2018

Codecov Report

Merging #8800 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #8800      +/-   ##
============================================
- Coverage     51.96%   51.96%   -0.01%     
- Complexity    25280    25283       +3     
============================================
  Files          1607     1607              
  Lines         94825    94827       +2     
  Branches       1377     1377              
============================================
- Hits          49280    49279       -1     
- Misses        45545    45548       +3
Impacted Files Coverage Δ Complexity Δ
apps/files/composer/composer/autoload_static.php 0% <ø> (ø) 1 <0> (ø) ⬇️
apps/files/appinfo/routes.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files/composer/composer/autoload_classmap.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files/lib/Controller/AjaxController.php 0% <0%> (ø) 3 <3> (?)
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
lib/private/Files/ObjectStore/SwiftFactory.php 52.74% <0%> (-1.1%) 36% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.7% <0%> (+0.24%) 136% <0%> (ø) ⬇️

Copy link
Copy Markdown
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants