Skip to content

Remove unused methods and constants from legacy OC_API#8788

Merged
MorrisJobke merged 1 commit intomasterfrom
cleanup-oc_api
Mar 13, 2018
Merged

Remove unused methods and constants from legacy OC_API#8788
MorrisJobke merged 1 commit intomasterfrom
cleanup-oc_api

Conversation

@MorrisJobke
Copy link
Copy Markdown
Member

Ref #8375 and #7827

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Copy Markdown
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bildschirmfoto von 2018-03-12 18-09-42 😍

*/

/** @deprecated Use \OCP\API::RESPOND_UNAUTHORISED instead */
const RESPOND_UNAUTHORISED = 997;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are still used I believe... we probably should migrate

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked all of the apps within this organization and all of the App Store - they are only used in the ocdownloader (see link above) and the others use the ones from the public interface ;)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah we have them double defined... but of course ...

@MorrisJobke MorrisJobke merged commit 57eaa48 into master Mar 13, 2018
@MorrisJobke MorrisJobke deleted the cleanup-oc_api branch March 13, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants