Remove unused and deprecated class and interface AppHelper#8784
Merged
MorrisJobke merged 1 commit intomasterfrom Mar 12, 2018
Merged
Remove unused and deprecated class and interface AppHelper#8784MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
MorrisJobke
requested review from
ChristophWurst,
nickvergessen,
rullzer and
skjnldsv
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
remove-unused-deprecated-apphelper
branch
from
5d1a54b to
f5c5c51
Compare
Codecov Report
@@ Coverage Diff @@
## master #8784 +/- ##
============================================
+ Coverage 51.87% 51.88% +<.01%
+ Complexity 25380 25376 -4
============================================
Files 1608 1607 -1
Lines 95157 95144 -13
Branches 1377 1377
============================================
Hits 49366 49366
+ Misses 45791 45778 -13
|
nickvergessen
approved these changes
Mar 12, 2018
skjnldsv
approved these changes
Mar 12, 2018
rullzer
approved these changes
Mar 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #8375