Skip to content

Remove deprecated functions from DI Container#7839

Merged
MorrisJobke merged 1 commit intomasterfrom
dep_dicontainer
Jan 14, 2018
Merged

Remove deprecated functions from DI Container#7839
MorrisJobke merged 1 commit intomasterfrom
dep_dicontainer

Conversation

@rullzer
Copy link
Copy Markdown
Member

@rullzer rullzer commented Jan 13, 2018

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2018

Codecov Report

Merging #7839 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #7839      +/-   ##
============================================
+ Coverage     51.21%   51.21%   +<.01%     
  Complexity    24956    24956              
============================================
  Files          1607     1607              
  Lines         95046    95046              
  Branches       1376     1376              
============================================
+ Hits          48674    48675       +1     
+ Misses        46372    46371       -1
Impacted Files Coverage Δ Complexity Δ
...e/AppFramework/DependencyInjection/DIContainer.php 78.6% <100%> (ø) 27 <0> (ø) ⬇️
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 81.55% <0%> (+0.11%) 134% <0%> (ø) ⬇️
lib/private/Group/Database.php 99.19% <0%> (+0.8%) 26% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

Copy link
Copy Markdown
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@MorrisJobke MorrisJobke merged commit 3ade5cc into master Jan 14, 2018
@MorrisJobke MorrisJobke deleted the dep_dicontainer branch January 14, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants