fix(core): prompt for password once when installing recommended apps#60165
Conversation
|
/backport to stable33 |
|
It will need backport to all versions the fix was backported to, sadly, but we can wait for the 33 backport first to watch for conflicts. |
|
Maybe an opportunity to expand the test coverage a bit: server/cypress/e2e/core/setup.ts Line 114 in fb67d5d Perhaps an "Install failure / success flow" coverage path (using one of the smaller bundles)? |
37b46df to
8226b01
Compare
Wire the password-confirmation interceptors into the recommendedapps entry point and switch the installer to a single bulk enable call so the strict password confirmation on enableApps is satisfied. Fixes #60068 -e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
376129d to
3a4bb2b
Compare
|
/backport to stable32 |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/60165/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 82fb2e1b aefd591b 3a4bb2be
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/60165/stable33Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/60165/stable33."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Fixes the regression introduced in #59764 where the install assistant's "Install recommended apps" button always failed with unauthorized responses.
AppSettingsController::enableAppsnow requires strict password confirmation, but theRecommendedApps.vueinstaller was calling it via plainaxios.post(...)without theconfirmPasswordoption (and therecommendedapps.jsentry point hadn't registered the password-confirmation interceptors). The per-app loop is also collapsed into a single bulk call so the user is prompted once instead of N times.Checklist
3. to review, feature component)stable32)