Skip to content

fix(tests): Fix encryption test isolation between test runs#60000

Merged
skjnldsv merged 1 commit into
nextcloud:masterfrom
cuppett:cuppett/test-isolation
Apr 30, 2026
Merged

fix(tests): Fix encryption test isolation between test runs#60000
skjnldsv merged 1 commit into
nextcloud:masterfrom
cuppett:cuppett/test-isolation

Conversation

@cuppett
Copy link
Copy Markdown
Contributor

@cuppett cuppett commented Apr 29, 2026

Summary

Add global encryption teardown to TestCase base class so encryption state does not leak between test suites regardless of which tests ran earlier.

Spawned from #57279

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Add global encryption teardown to TestCase base class so encryption state
does not leak between test suites regardless of which tests ran earlier.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Stephen Cuppett <steve@cuppett.com>
@cuppett cuppett requested a review from a team as a code owner April 29, 2026 23:45
@cuppett cuppett requested review from Altahrim, ArtificialOwl, leftybournes and salmart-dev and removed request for a team April 29, 2026 23:45
@cuppett cuppett added this to the Nextcloud 34 milestone Apr 29, 2026
@skjnldsv
Copy link
Copy Markdown
Member

Congrats on the 60000th GitHub ticket! 🎊🎊

Copy link
Copy Markdown
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense to me

@skjnldsv skjnldsv merged commit 723b441 into nextcloud:master Apr 30, 2026
205 of 225 checks passed
@cuppett cuppett deleted the cuppett/test-isolation branch April 30, 2026 10:53
This was referenced May 5, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants