fix(notifications): dismiss comment mention notifications when viewed…#59811
Open
miaulalala wants to merge 3 commits into
Open
fix(notifications): dismiss comment mention notifications when viewed…#59811miaulalala wants to merge 3 commits into
miaulalala wants to merge 3 commits into
Conversation
miaulalala
added
3. to review
miaulalala
requested review from
Altahrim,
ArtificialOwl,
nfebe,
sorbaugh and
szaimen
and removed request for
a team
szaimen
requested review from
edward-ly and
susnux
and removed request for
szaimen
miaulalala
force-pushed
the
fix/2531/comments-not-marked-read
branch
from
d4bdf44 to
3bcb4d1
Compare
Contributor
Author
|
/compile amend |
nextcloud-command
force-pushed
the
fix/2531/comments-not-marked-read
branch
from
3bcb4d1 to
69aee5d
Compare
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Resolved in commit 169be0b. The branch now has a merge commit bringing it up to date with current master. The only conflicting file was the binary |
Contributor
Author
|
/compile amend |
nextcloud-command
force-pushed
the
fix/2531/comments-not-marked-read
branch
from
169be0b to
1cea17e
Compare
… in activity sidebar
Add a `DELETE /notifications/dismiss/{id}` endpoint to the comments
NotificationsController that marks the `comments/comment/mention`
notification as processed without redirecting.
When comments are loaded in the activity sidebar, the frontend calls
this endpoint for any comment that mentions the current user, so the
notification is cleared from the bell without requiring the user to
navigate via the notification link.
Fixes: nextcloud/activity#2531
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
… is opened When comments are loaded via the activity sidebar integration, call markCommentsAsRead() (PROPPATCH readMarker) so the server-side unread count is reset, and immediately update the node attribute to zero so the badge disappears from the files list without requiring a page reload. The regular comments tab (CommentsApp.vue) already called markCommentsAsRead on visibility; this brings the activity integration path to parity. Fixes: nextcloud/activity#2531 Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Verify that: - the unread badge appears in the files list when another user has left a comment on a file - the badge is removed immediately (no page reload) after opening the sidebar, and that the readMarker PROPPATCH is sent to the server - the badge stays absent after the sidebar is closed again Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
miaulalala
force-pushed
the
fix/2531/comments-not-marked-read
branch
from
1cea17e to
a0dd846
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in activity sidebar
Summary
Add a
DELETE /notifications/dismiss/{id}endpoint to the comments NotificationsController that marks thecomments/comment/mentionnotification as processed without redirecting.When comments are loaded in the activity sidebar, the frontend calls this endpoint for any comment that mentions the current user, so the notification is cleared from the bell without requiring the user to navigate via the notification link.
Fixes: nextcloud/activity#2531
AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com
Checklist
Screenshots before/after for front-end changes3. to review, feature component)stable32)AI (if applicable)