fix(zip): suppress sabre/dav response only if stream was actually sent#59382
Open
fix(zip): suppress sabre/dav response only if stream was actually sent#59382
Conversation
eaba5d5 to
570c914
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
570c914 to
d03604a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
afterDownloadcurrently returnsfalse(suppressing sabre/dav's own response logic) for any GET request targeting a Directory node, regardless of whetherhandleDownloadactually streamed an archive.This means a GET on a folder without an
Accept: ziporAccept: tarheader causeshandleDownloadto correctly bail out with null, butafterDownloadthen silently swallows sabre/dav's response, resulting in an empty reply to the client instead of the expected.The fix: suppress sabre/dav response only if stream was actually sent.
Checklist
3. to review, feature component)stable32)AI (if applicable)