Skip to content

fix(zip): suppress sabre/dav response only if stream was actually sent#59382

Open
solracsf wants to merge 1 commit intomasterfrom
supressStreamSabreDav
Open

fix(zip): suppress sabre/dav response only if stream was actually sent#59382
solracsf wants to merge 1 commit intomasterfrom
supressStreamSabreDav

Conversation

@solracsf
Copy link
Copy Markdown
Member

@solracsf solracsf commented Apr 1, 2026

Summary

afterDownload currently returns false (suppressing sabre/dav's own response logic) for any GET request targeting a Directory node, regardless of whether handleDownload actually streamed an archive.

This means a GET on a folder without an Accept: zip or Accept: tar header causes handleDownload to correctly bail out with null, but afterDownload then silently swallows sabre/dav's response, resulting in an empty reply to the client instead of the expected.

The fix: suppress sabre/dav response only if stream was actually sent.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@solracsf solracsf requested a review from a team as a code owner April 1, 2026 12:49
@solracsf solracsf requested review from ArtificialOwl, CarlSchwan, artonge and provokateurin and removed request for a team April 1, 2026 12:50
@solracsf solracsf force-pushed the supressStreamSabreDav branch from eaba5d5 to 570c914 Compare April 1, 2026 12:53
@CarlSchwan

This comment was marked as resolved.

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the supressStreamSabreDav branch from 570c914 to d03604a Compare April 1, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants