fix(sharing): icon color mismatch on download button in public share#59175
fix(sharing): icon color mismatch on download button in public share#59175rodrigocorreiaist wants to merge 4 commits into
Conversation
rodrigocorreiaist
requested review from
nfebe,
skjnldsv and
szaimen
and removed request for
a team
|
/backport to stable33 |
|
/backport to stable32 |
|
/compile rebase |
|
@rodrigocorreiaist thanks for the PR! Can you please provide before and after screenshots? Also, can you please commit and push the compiled assets? Thanks in advance! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hi @szaimen! I've added before and after screenshots to the PR description. I've also compiled the assets and pushed them to the branch (dist/core-public-page-menu.js and related files). Thank you for the review! |
|
/compile / |
joshtrichards
changed the title
… share The download button icon on the public share page always appeared in the opposite color of the button text. The root cause was the wrong CSS variable for the filter applied to the icon. Background-image icons are dark (black) by default. In light mode, the icon must be inverted to white when the primary color is dark, which requires --primary-invert-if-dark. The code was incorrectly using --primary-invert-if-bright, inverting in the wrong direction. In dark mode, icons.css swaps the icon variables so that --icon-download-dark resolves to the white SVG. The filter logic must be reversed: --primary-invert-if-bright is needed to invert the white icon to black when the primary color is bright. Fix by using --primary-invert-if-dark in light mode and --primary-invert-if-bright in dark mode, handling both the prefers-color-scheme media query and the Nextcloud data-themes attribute for explicit theme selection. Signed-off-by: Rodrigo Mendes Correia <rodrigo.mendes.correia@tecnico.ulisboa.pt>
rodrigocorreiaist
force-pushed
the
fix/57282-download-button-icon-color
branch
from
fc26cf7 to
29b040a
Compare
3 participants
Summary
Fixes #57282
The download button icon on the public share page always appeared in the opposite color of the button text.
Root cause
The icon uses a CSS background-image (
.icon-download) which is dark (black) by default. The filtervar(--primary-invert-if-bright)was applied to it, but this variable inverts the icon in the wrong direction:--primary-invert-if-bright=no→ icon stays black, but text is white → mismatch ❌--primary-invert-if-bright=invert(100%)→ icon becomes white, but text is black → mismatch ❌Fix
In light mode, the correct variable is
--primary-invert-if-dark, which inverts the dark icon to white when the primary color is dark (matching the white text).In dark mode,
icons.cssswaps the icon CSS variables so that--icon-download-darkresolves to the white SVG. This means the filter logic must be reversed:--primary-invert-if-brightcorrectly inverts the white icon to black when the primary color is bright (matching the black text).Both the
prefers-color-scheme: darkmedia query and the Nextclouddata-themesattribute (used for explicit theme selection in Settings) are handled.