Skip to content

fix(lib): templates core path detection#58872

Merged
skjnldsv merged 1 commit intomasterfrom
fix/templatespath
Apr 2, 2026
Merged

fix(lib): templates core path detection#58872
skjnldsv merged 1 commit intomasterfrom
fix/templatespath

Conversation

@skjnldsv
Copy link
Copy Markdown
Member

@skjnldsv skjnldsv commented Mar 11, 2026

Summary

For some reason, since NC32, the getAppTemplateDirs function returns themes/example/apps/core/templates for core templates, while it used to return themes/example/core/templates.
In any case, seeign the method below, I fully assume this was a mistake initially and that if the app was core, the getCoreTemplateDirs should have been used 🤷

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 34 milestone Mar 11, 2026
@skjnldsv skjnldsv self-assigned this Mar 11, 2026
@skjnldsv skjnldsv requested a review from a team as a code owner March 11, 2026 16:28
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels Mar 11, 2026
@skjnldsv skjnldsv requested review from Altahrim, ArtificialOwl and icewind1991 and removed request for a team March 11, 2026 16:28
@skjnldsv skjnldsv requested a review from salmart-dev March 11, 2026 16:28
@skjnldsv
Copy link
Copy Markdown
Member Author

/backport to stable33

@skjnldsv
Copy link
Copy Markdown
Member Author

/backport to stable32

@skjnldsv skjnldsv requested review from CarlSchwan and come-nc and removed request for ArtificialOwl and icewind1991 March 11, 2026 16:29
@skjnldsv skjnldsv merged commit ca3f77b into master Apr 2, 2026
171 of 174 checks passed
@skjnldsv skjnldsv deleted the fix/templatespath branch April 2, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants