feat(userList): Allow to list all users#57179
Conversation
77748c1 to
b585280
Compare
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
miaulalala
left a comment
There was a problem hiding this comment.
What's the highest amount of users you've tested this with? I'm a bit worried about running out of memory - I think it would be wise to chunk the output to something like 500 or 1000 users per call to writeArrayInOutputFormat
|
@miaulalala You would still have all users in memory, no? |
11.768 in a public instance (using LDAP). |
|
Also please note that this PR is not different from something like |
|
/backport to stable33 |
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/57179/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b5852805
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57179/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable33 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/57179/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b5852805
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57179/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
Apparently this was merged before the 34 branch-off already. So no backport to stable33 required |
--limit 0to disableuser:listlimit #57120Summary
Updated the limit option to allow
--limit=0for unlimited users listing.This PR simply passes null to underlying methods since
IUserManager::searchDisplayName()andIUserManager::getDisabledUsers()acceptnullfor the limit parameter.Checklist
3. to review, feature component)stable32)