Open
Conversation
SebastianKrupinski
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
salmart-dev
and removed request for
a team
tcitworld
reviewed
Jan 12, 2026
Comment on lines
+310
to
+314
| if (str_starts_with($line, 'X-WR-CALNAME:')) { | ||
| $calendarName = substr($line, 13); | ||
| } elseif (str_starts_with($line, 'X-APPLE-CALENDAR-COLOR:')) { | ||
| $calendarColor = substr($line, 23); | ||
| } |
Member
There was a problem hiding this comment.
Why relying on non-standard properties since you've already got this information in the calendar meta?
Contributor
Author
There was a problem hiding this comment.
This is for compatibility... the first version of the migrator only created a single ICS file with custom properties for the name... part of the improvements is the ".meta" file.
SebastianKrupinski
force-pushed
the
feat/improve-calendar-migrator
branch
from
d27c7f9 to
1899e5f
Compare
Merged
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
feat/improve-calendar-migrator
branch
from
1899e5f to
bad2541
Compare
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 11, 2026
Merged
Merged
Member
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Checklist
3. to review, feature component)stable32)