fix(Memcache): ensure global prefix depends on enabled apps#56033
Merged
fix(Memcache): ensure global prefix depends on enabled apps#56033
Conversation
- ensure the prefix is changed when an app is (dis)enabled - ensure the app ids are included in the hash instead of only the version numbers - ensure hash is deterministic by always use the same order. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
Author
|
/backport to stable32 |
CarlSchwan
approved these changes
Oct 27, 2025
artonge
approved these changes
Oct 28, 2025
Member
|
There is still a problem with maintenance mode and cached routes even with this fix. The global prefix is the same if the maintenance mode is enabled or disabled. However, the routes generated during maintenance mode do not seem to include apps/XXX routes. Therefore, if the route cache is generated while in maintenance mode the cache is not valid once the maintenance mode is disabled, but the same cache will be still used, thus leading to Page not found errors. Routes can be generated even while in maintenance mode due to a special handling of JavaScript files, which skip the maintenance mode and are matched even in that case, which cause the route cache to be regenerated if it was empty. How to reproduce:
|
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
see also #54383 (comment)
Checklist
3. to review, feature component)stable32)