fix: Drop unnecessary exit

[artonge]

This is making the CI stop for no good reason.

[come-nc]

I will push commits here to fix the tests if needed because I broke at least ServerTest in the mean time.

[provokateurin]

Looks like it also hid some errors from the PR that caused this @artonge

[come-nc]

Tests from #47986 were completely broken, I fix the most obvious errors but for the rest I leave it up to @icewind1991 or anyone willing.

[come-nc]

PHP Fatal error:  Cannot redeclare print_exception() (previously declared in /home/runner/actions-runner/_work/server/server/core/templates/xml_exception.php:8) in /home/runner/actions-runner/_work/server/server/core/templates/xml_exception.php on line 8
Script phpunit --configuration tests/phpunit-autotest.xml handling the test event returned with error code 255
Script @composer run test -- --group DB,SLOWDB handling the test:db event returned with error code 255

[come-nc]

PHP Fatal error:  Cannot redeclare print_exception() (previously declared in /home/runner/actions-runner/_work/server/server/core/templates/xml_exception.php:8) in /home/runner/actions-runner/_work/server/server/core/templates/xml_exception.php on line 8
Script phpunit --configuration tests/phpunit-autotest.xml handling the test event returned with error code 255
Script @composer run test -- --group DB,SLOWDB handling the test:db event returned with error code 255

This is from apps/dav/tests/unit/Connector/Sabre/RequestTest/UploadTest.php but I do not understand the issue.

[cfiehe]

Tests from #47986 were completely broken, I fix the most obvious errors but for the rest I leave it up to @icewind1991 or anyone willing.

@come-nc
Thanks for fixing and sorry for the trouble. The test runs were blocked on my fork, otherwise I would have tried to fix the issues before. I have not found a way to get them running locally. Is there any way to see, if the new tests succeed or still cause trouble?

[come-nc]

Tests from #47986 were completely broken, I fix the most obvious errors but for the rest I leave it up to @icewind1991 or anyone willing.

@come-nc Thanks for fixing and sorry for the trouble. The test runs were blocked on my fork, otherwise I would have tried to fix the issues before. I have not found a way to get them running locally. Is there any way to see, if the new tests succeed or still cause trouble?

They still fail, you cannot see the failures in CI yet because there is a crash but @artonge just fixed it so next run should show them hopefully.
You should be able to run them locally with: ./autotest.sh sqlite tests/lib/Files/ObjectStore/
I do not remember if composer install first is needed and if it is enough to setup phpunit though.

[come-nc]

@artonge the exit drop needs to be backported I think?

[kesselb]

/backport to stable30

[kesselb]

/backport to stable29

[kesselb]

/backport to stable28

[icewind1991]

Tests from #47986 were completely broken, I fix the most obvious errors but for the rest I leave it up to @icewind1991 or anyone willing.

@come-nc Thanks for fixing and sorry for the trouble. The test runs were blocked on my fork, otherwise I would have tried to fix the issues before. I have not found a way to get them running locally. Is there any way to see, if the new tests succeed or still cause trouble?

They still fail, you cannot see the failures in CI yet because there is a crash but @artonge just fixed it so next run should show them hopefully. You should be able to run them locally with: ./autotest.sh sqlite tests/lib/Files/ObjectStore/ I do not remember if composer install first is needed and if it is enough to setup phpunit though.

#48160 fixes them

[artonge]

/backport d2bf361 to stable30

[artonge]

/backport d2bf361 to stable29

[artonge]

/backport d2bf361 to stable28

[backportbot]

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/48145/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d2bf3613

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48145/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/48145/stable30."}

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[backportbot]

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/48145/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d2bf3613

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48145/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/48145/stable29."}

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[backportbot]

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/48145/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d2bf3613

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48145/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/48145/stable28."}

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[icewind1991]

#48205 for a backport that includes all the fixes needed to get ci green