Refined BackgroundCleanupJob queries for robustness, allowing CACHEDIR.TAG in preview root#46072
Refined BackgroundCleanupJob queries for robustness, allowing CACHEDIR.TAG in preview root#46072dennisverspuij wants to merge 2 commits intonextcloud:masterfrom
Conversation
…R.TAG in preview root Signed-off-by: Dennis Verspuij <6680484+dennisverspuij@users.noreply.github.com>
|
Related: #42540 Haven't tested it but looks reasonable. I am not sure if I like the idea of having unrelated files there, but I see the use case. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hello, #48581 has been merged to fix the same thing, and it showed better performances. So, closing this one. |
I personally like NextCloud AIO to exclude previews from backup, by adding a appdata_*/preview/CACHEDIR.TAG file.
However the queries of the \OC\Preview\BackgroundCleanupJob (may) fail because of this,
This PR fixes this by making the queries more precise.