fix(LDAP): do not count mapped users x-times active configs#44767
Draft
fix(LDAP): do not count mapped users x-times active configs#44767
Conversation
- the method counts all rows in the mapping tables, which are not specific to single configurations, but contains users from all Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
a team,
come-nc,
sorbaugh and
yemkareems
and removed request for
a team
come-nc
reviewed
Apr 11, 2024
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Then the method should be moved out of User_LDAP and directly in User_Proxy if it’s not specific to a connection.
Member
Author
Actually yes, and it crossed my mind yesterday as well. Revisiting this, I am not sure anymore why I decided against it – possibly to avoid injecting another dependency. But actually the abstract Proxy class pulls it in anyway (though on demand). |
blizzz
added
2. developing
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the method counts all rows in the mapping tables, which are not specific to single configurations, but contains users from all
So if you are operating on a one-click host with a user limit of 500, but have two LDAPs connected with altogether 300 users, without this fix they are interpreted as 600 users, and the 301st could not log in.
Checklist