Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
9dbac0d to
d1db634
Compare
d1db634 to
c107174
Compare
|
@Pytal please review the logic! Especially the condition on where a reminder is shown or not, as I wasn't part of the original discussions! I used your services, so I think it should be good.
|
c107174 to
d0290e3
Compare
Yes this is by design
Yes, if you can see (read) the file then you should be able to set a reminder on it |
apps/files_reminders/src/actions/setReminderSuggestionActions.scss
Outdated
Show resolved
Hide resolved
apps/files_reminders/src/actions/setReminderSuggestionActions.ts
Outdated
Show resolved
Hide resolved
apps/files_reminders/src/actions/setReminderSuggestionActions.ts
Outdated
Show resolved
Hide resolved
dcf6e36 to
d5371bd
Compare
d5371bd to
48a5e4d
Compare
susnux
left a comment
There was a problem hiding this comment.
The focus handling does not work properly:
If you click (keyboard) on "set reminder" the submenu opens but the focus is not set on the submenu's first element.
Also if you click the back button the first submenu is reopend, but the focus is not on the "set reminder" entry.
In both cases the focus is on some random non visible element.
| } | ||
|
|
||
| // Generate the default preset actions | ||
| export const actions = [laterToday, tomorrow, thisWeekend, nextWeek] |
There was a problem hiding this comment.
Since the presence of the action should be evaluated ideally on click instead of on script execution I think the FileAction enabled callback needs to be set to something like () => Boolean(getDateTime(option.dateTimePreset)) to be more reactive
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
48a5e4d to
32c1aeb
Compare
Uh oh!
There was an error while loading. Please reload this page.