feat(dashboard): implement widget item api v2#39937
Merged
nickvergessen merged 2 commits intomasterfrom Aug 22, 2023
Merged
Conversation
This was referenced Aug 17, 2023
4307fb5 to
87752ab
Compare
tcitworld
reviewed
Aug 18, 2023
nickvergessen
approved these changes
Aug 21, 2023
Member
nickvergessen
left a comment
There was a problem hiding this comment.
Needs a rebase, but otherwise seems fine and functional
AndyScherzinger
approved these changes
Aug 21, 2023
76f8c59 to
a01210f
Compare
Member
Author
|
/backport 6982597 to stable27 |
This API enables the dashboard to render all widgets from the API data alone without having apps to provide their own bundles. This saves a lot of traffic and execution time as a lot less javascript has to be parsed on the frontend. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Rebasing |
a01210f to
e1accaf
Compare
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Member
|
/backport 6982597 to stable27 |
Member
|
Will have to do it manually, the OpenAPI stuff does not exist on stable27 |
Member
|
PS I'm on it aklready |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Aug 22, 2023
Ref nextcloud/server#39937 Signed-off-by: Joas Schilling <coding@schilljs.com>
4 tasks
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Aug 22, 2023
Ref nextcloud/server#39937 Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Aug 22, 2023
Ref nextcloud/server#39937 Signed-off-by: Joas Schilling <coding@schilljs.com>
backportbot-nextcloud bot
pushed a commit
to nextcloud/spreed
that referenced
this pull request
Aug 22, 2023
Ref nextcloud/server#39937 Signed-off-by: Joas Schilling <coding@schilljs.com>
9 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This API enables the dashboard to render all widgets from the API data alone without having apps to provide their own bundles. This saves a lot of traffic and execution time as a lot less javascript has to be parsed on the frontend.
This is already done on the clients. However, the dashboard requires some extra logic and data as its widgets tend to be more sophisticated. To prevent breaking all apps and clients new API (v2) was introduced allowing each app and each client to migrate at their own pace.
Profiling results
Perceived loading time: Time from hitting refresh until all dashboard widgets finished loading.
No cache: Simulates a new visitor or a visitor returning after a long time. Cache is disabled in Chrome DevTools to force the browser to redownload all assets.
Cache: Simulates a user that often uses Nextcloud. Browser cache is enabled.
Tests were run on the same instance with exactly the same calendar, mail and spreed data etc.
Before
Without cache
Time until all widgets finised loading: 4284 ms
Chrome network stats:
With cache
Time until all widgets finised loading: 3836 ms
Chrome network stats:
After
Without cache
Time until all widgets finished loading: 2995 ms
Chrome network stats:
With cache
Time until all widgets finished loading: 1500 ms
Chrome network stats:
TODO
Checklist