Fixes Issue 35286 Firefox inconsistent scrolling#37297
Fixes Issue 35286 Firefox inconsistent scrolling#37297sorbaugh wants to merge 2 commits intonextcloud:masterfrom
Conversation
szaimen
requested review from
a team,
Pytal,
artonge,
miaulalala and
skjnldsv
and removed request for
a team
|
Can you also run |
|
Hello! I ran npm run build as requested, which altered 98 files in the /dist directory of my fork. The purpose of these changes seem to be mainly for cache-busting / adding a new version number to the source-mapping url. Since I'm new to contributing in nextcloud and the main change is so small, it feels kind of overkill to commit this many files. So before I commit I wanted to ask if this is ok? Best regards |
Indeed, not the best, but this is how we currently do things :) So you can commit and push those files. |
URL: nextcloud#35286 Adding overflow-anchor: none to #app-content element within files.scss and re-minified files.css and merged.css. Tested on Firefox 111.0 (64-Bit) Signed-off-by: Stephan <stephan_orbaugh@outlook.de>
URL: nextcloud#35286 Added comment clarifying the purpose of the previous change. Adding /dist files after npm run build Tested on Firefox 111.0 (64-Bit) Signed-off-by: Stephan Orbaugh <stephan_orbaugh@hotmail.com> Signed-off-by: Stephan <stephan_orbaugh@outlook.de>
|
Ok I assume the conflicts with the /dist directory were to be expected if npm run build is run frequently :) If everything else is alright and ready for merge, I can do a rebase. |
Yes, please rebase, compile, commit and push again :) |
3 participants
Summary
URL: #35286
Adding overflow-anchor: none to #app-content element within files.scss and re-minified files.css and merged.css.
Tested on Firefox 111.0 (64-Bit)
TODO
Checklist