Add color variables for text on blurred background#34299
Merged
Conversation
Merged
Member
|
master is still 26, please trigger a backport if necessary |
Contributor
Member
It should be dispatched to the DarkTheme.php as well as there is a darken usage (so should be lighten on dark themes) |
jancborchardt
approved these changes
Oct 3, 2022
8136c36 to
2558bf0
Compare
2558bf0 to
e69abfb
Compare
Member
Author
|
/backport to stable25 |
e69abfb to
888d35b
Compare
Member
|
This is important for accessibility, could you review @skjnldsv @szaimen @juliushaertl @marcoambrosini? :) |
AndyScherzinger
approved these changes
Oct 11, 2022
Signed-off-by: Christopher Ng <chrng8@gmail.com>
888d35b to
8c4de8f
Compare
Member
Author
|
Also made sure that text remains high contrast in high contrast modes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds variables required for nextcloud-libraries/nextcloud-vue#3307
Compared to
--color-text-maxcontrastthe new--color-text-maxcontrast-background-bluris darker in light mode and lighter in dark modeLight mode:
#767676->#646464Dark mode:
#8C8C8C->#919191