Fix log_type errorlog: should behave like other log handlers#34256
Closed
znerol wants to merge 1 commit intonextcloud:masterfrom
Closed
Fix log_type errorlog: should behave like other log handlers#34256znerol wants to merge 1 commit intonextcloud:masterfrom
znerol wants to merge 1 commit intonextcloud:masterfrom
Conversation
9 tasks
9f96510 to
e66e753
Compare
e66e753 to
47a04be
Compare
Signed-off-by: znerol <lo+github@znerol.ch>
47a04be to
774bbab
Compare
Contributor
|
Is there any activity on having this patch accepted? |
Member
|
I coincidentally submit a very similar PR at #35614. Let's take this one. But please revive the |
6 tasks
Author
If |
Member
|
Then let's continue in #35614. Mind giving the other PR a review? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration with
'log_type' => 'errorlog'are affected by #33313. This is due to the fact that theErrorLoghandler currently doesn't correctly implement thewrite()method. According to other implementations, the$messageparameter can be either a string or an array.Other implementations use
logDetailsAsJSONto convert a structured log message into astring.ErrorLogshould do the same.Note: This PR also removes the
$taginstance variable. A log tag is important for writers likesyslogandsystemdwhere log messages of multiple subsystems are merged into a common journal. This is clearly not the case for theerrlogwriter.