[stable20] Use unique combination of hostname/bucket/key for external storages#29634
Merged
[stable20] Use unique combination of hostname/bucket/key for external storages#29634
Conversation
0645941 to
439a0bf
Compare
MichaIng
requested changes
Nov 18, 2021
Member
MichaIng
left a comment
There was a problem hiding this comment.
Backport is now complete, but the migration seems to make use of changed interfaces.
Member
|
Marking as closed as NC20 is EOL. If wanted to customers, it can be reopened at any time. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
439a0bf to
998e631
Compare
Member
|
Rebased, seems like @CarlSchwan already resolved the conflicts, but needs another testing round. |
Member
|
CI is unhappy, related to files_external app. |
juliusknorr
approved these changes
Jul 7, 2022
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
|
Adjusted the migration to work with the query builder on 20 and tested the migration path again. |
f4cec03 to
68a4285
Compare
nickvergessen
approved these changes
Jul 8, 2022
Member
|
failing test unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #29484