Tokens without password should not trigger changed password invalidation#29122
Merged
ChristophWurst merged 1 commit intomasterfrom Oct 11, 2021
Merged
Tokens without password should not trigger changed password invalidation#29122ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
7dff30e to
508fe18
Compare
ChristophWurst
approved these changes
Oct 11, 2021
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
|
/backport to stable20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this app passwords that were generated through a login method that doesn't provide a password (e.g. when using an oidc id token as bearer auth header) did invalidate themselves on the first use (after the 5 minute offset for token checking).
Steps to reproduce:
curl -X GET "https://nextcloud.local/ocs/v1.php/core/getapppassword" -H "OCS-APIRequest: true" -H "Accept: application/json" -H "Authorization: Bearer OIDC_ID_TOKEN"This is similar to #27886 but gets only triggered when using an IApacheBackend where an empty string is set in
server/lib/private/legacy/OC_User.php
Line 193 in 57a816a