Skip to content

Comments

l10n: Remove a text string from translation#28698

Merged
Valdnet merged 2 commits intomasterfrom
Valdnet-patch-1
Sep 13, 2021
Merged

l10n: Remove a text string from translation#28698
Valdnet merged 2 commits intomasterfrom
Valdnet-patch-1

Conversation

@Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Sep 3, 2021

Removal of a text string from a translation in Transifex.

Signed-off-by: Valdnet 47037905+Valdnet@users.noreply.github.com

@Valdnet Valdnet added the feature: language/translations (l10n/i18n) Localization and translation matters label Sep 3, 2021
nickvergessen
nickvergessen requested changes Sep 3, 2021
View reviewed changes
@rakekniven rakekniven requested review from rakekniven and removed request for rakekniven September 3, 2021 16:56
rakekniven
rakekniven reviewed Sep 3, 2021
View reviewed changes
Copy link
Member

@rakekniven rakekniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will stop reviewing such things without being a coder ;-)

@rakekniven rakekniven self-requested a review September 3, 2021 16:57
@Valdnet
Copy link
Contributor Author

Valdnet commented Sep 3, 2021

I will stop reviewing such things without being a coder ;-)

@rakekniven I'm not a programmer either. I did some coding there, but we can always rely on developers like nickvergessen.

@rakekniven
Copy link
Member

rakekniven commented Sep 3, 2021

I will stop reviewing such things without being a coder ;-)

@rakekniven I'm not a programmer either. I did some coding there, but we can always rely on developers like nickvergessen.

Yes, that is fine for me.

In my case I approved your change as a reviewer and that was wrong.

@nextcloud nextcloud deleted a comment Sep 5, 2021
@nextcloud nextcloud deleted a comment Sep 5, 2021
@nextcloud nextcloud deleted a comment Sep 5, 2021
@nextcloud nextcloud deleted a comment Sep 5, 2021
@nextcloud nextcloud deleted a comment Sep 5, 2021
@nextcloud nextcloud deleted a comment Sep 5, 2021
@nextcloud nextcloud deleted a comment Sep 5, 2021
@nextcloud nextcloud deleted a comment Sep 5, 2021
@rakekniven rakekniven removed their request for review September 6, 2021 10:09
@szaimen szaimen added the 3. to review Waiting for reviews label Sep 13, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Sep 13, 2021
szaimen
szaimen approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen
Copy link
Contributor

szaimen commented Sep 13, 2021

/rebase

@Valdnet @szaimen
l10n: Remove a text string from translation
a097695 
Removal of a text string from a translation in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@Valdnet @szaimen
Correct code
325aa48 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@Valdnet Valdnet merged commit a6ef9df into master Sep 13, 2021
@Valdnet Valdnet deleted the Valdnet-patch-1 branch September 13, 2021 13:27
@Valdnet
Copy link
Contributor Author

Valdnet commented Sep 15, 2021

/backport to stable22

@Valdnet
Copy link
Contributor Author

Valdnet commented Sep 15, 2021

/backport to stable21

@Valdnet
Copy link
Contributor Author

Valdnet commented Sep 15, 2021

/backport to stable20

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 15, 2021

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 15, 2021

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakekniven rakekniven rakekniven approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

4 participants

@Valdnet @rakekniven @szaimen @nickvergessen