Let memory limit set in tests fit the used amount#28122
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
julien-nc
approved these changes
Jul 22, 2021
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Didn't try it but seems ✔️ to me
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
Author
|
Backports to stable20 as it might also occur with php-7.4.21 or later |
Pytal
approved these changes
Jul 22, 2021
Pytal
added
4. to release
This was referenced Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent bump of the php8.0 container it seems that setting a memory limit smaller than the currently used amount of memory is throwing an error in the tests. This PR makes sure that the values we use for testing fits with what is used by running the full testsuite in phpunit.
Should make the nodb tests pass again.
For some background it seems that php/php-src@1b3b5c9 introduced a warning for that case while fixing a bug and phpunit is letting the tests fail due to the convertWarningsToExceptions="true" default. However with the php upstream fix the tests would also no longer have passed as the previous memory limit value would have been kept then.