add text/org mimetype#24488
Conversation
juliusknorr
left a comment
There was a problem hiding this comment.
We also need to add this to the repair step as in 9708b00, otherwise existing files will not get the new mimetype.
|
sure. what would be a reasonable version number for the test |
|
The current one on master would be 21.0.0.7 https://github.com/nextcloud/server/blob/master/version.php#L32. So taking that makes sure that once 21 is released every instance upgraded from below will run the mimetype repair. |
|
i've added another commit. let me know if anything else is needed... |
|
Looks good to me now 👍 There is only one thing missing - you need to add a sign-off message to the commits you made. Read more about this in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work |
|
i've amended the commits (or branch?) and it looks ok with |
https://github.com/nextcloud/server/pull/24488/checks?check_run_id=1536789034 for more details. You may squash the commits together. That's easier to sign off. |
|
thanks for the pointer @kesselb |
|
Mind to do another rebase? 3 out 5 commit seems unrelated. |
Signed-off-by: nik gaffney <nik@fo.am>
Signed-off-by: nik gaffney <nik@fo.am>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
The text app (or any future editor) should be able to edit .org files when
text/organdtext/plainMIME types are set and the webserver is correctly configured (based on comments from nextcloud/text#1205 )