add events to check passwords with the password policy app

[schiessle]

Send "validate password events" to allow the password policy app (https://github.com/nextcloud/password_policy) to validate the password.

[LukasReschke]

Any need of a new hook over '\OC\Share', 'verifyPassword'?

I'm fine with adding this one here as public API as well. But then the old one should die, it's non-public API anyways.

[schiessle]

Any need of a new hook over '\OC\Share', 'verifyPassword'?

I would like to have this new event as some kind of "public API" that other apps can check their passwords as well. This already speaks against a hook in the OC namespace. Further the symphony events have some advantages. E.g. the password checker can throw a exception and you can handle it outside of the hook, while the old hook system swallows all exception.

Let's try to have clean implementations of new stuff.

[schiessle]

Ready to review. You need the password policy app to test it: nextcloud/password_policy#1

Password policy should be checked for public links and for the database backend password change in the user management and password change in the personal settings

cc @LukasReschke @MorrisJobke @blizzz

[LukasReschke]

@schiessle Merge conflict 🙈

[LukasReschke]

That's a void method. No return required.

[schiessle]

@LukasReschke merge conflict resolved.

[LukasReschke]

LGTM 👍

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

Backport? cc @karlitschek

[karlitschek]

please backport 👍

[schiessle]

backport for 9.0.52 #240