switches the oc dialog button row to flex#10679
Merged
Conversation
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
weeman1337
added
bug
design
juliusknorr
approved these changes
Aug 13, 2018
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Nice 👍 Works as expected now in Firefox, Chrome, Safari and IE
Member
|
Thanks for fixing @weeman1337 |
skjnldsv
approved these changes
Aug 14, 2018
skjnldsv
added
4. to release
Member
|
@weeman1337 cool, good fix! :) Also added you to the design team, looking forward to more design contributions from you! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that c90d7c1 fixed the button layout for safari, but broke it for others.
As a possible solution I switched the button row layout to flex. It now fits in Chrome, Firefox and Safari.
For visual tests I found three possible button configurations:
closes #10667