Fix header menu & contact popover#10608
Merged
juliusknorr merged 4 commits intomasterfrom Aug 16, 2018
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
bug
design
skjnldsv
requested review from
ChristophWurst,
juliusknorr,
nickvergessen and
rullzer
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
This comment has been minimized.
This comment has been minimized.
Member
|
Should the popover start below the avatar, or in the middle? |
Member
Member
|
jsunit is not happy |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
rullzer
approved these changes
Aug 15, 2018
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Fine by me. But maybe starting below the avatar is better. Yet still nice to get this in :D
juliusknorr
approved these changes
Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nickvergessen can you edit this to your notification app?