Skip to content

Correctly calculate directory sizes when using an object store primary storage#1630

Merged
CarlSchwan merged 1 commit intomasterfrom
work/object-storage-compatibility
Aug 17, 2021
Merged

Correctly calculate directory sizes when using an object store primary storage#1630
CarlSchwan merged 1 commit intomasterfrom
work/object-storage-compatibility

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

An object store storage should use a NoopScanner since it is not
possible to scan the directory structure of an object-store. This makes
sure that the group folder mount point doesn't override the NoopScanner
that the object store storage use.

@CarlSchwan CarlSchwan force-pushed the work/object-storage-compatibility branch from ca51597 to 6a93479 Compare August 16, 2021 14:02
Comment thread lib/Mount/GroupFolderStorage.php Outdated
@skjnldsv skjnldsv added 2. developing Items that are currently under development bug labels Aug 16, 2021
@CarlSchwan CarlSchwan force-pushed the work/object-storage-compatibility branch from 6a93479 to c9e8ba0 Compare August 16, 2021 15:28
Copy link
Copy Markdown
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, now I finally understand it. Makes absolute sense 👍

@PVince81
Copy link
Copy Markdown
Member

@CarlSchwan can you rebase ? it seems this repo has stricter rules to have up to date branches before merging.

@PVince81 PVince81 added 4. to release Items that are ready for releasing and removed 2. developing Items that are currently under development labels Aug 17, 2021
…y storage

A object store storage should use an NoopScanner since it is not
possible to scan the directory structure of an object store. This makes
sure that the group folder mount point doesn't override the NoopScanner
that the object store storage use.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the work/object-storage-compatibility branch from c9e8ba0 to a9cf6da Compare August 17, 2021 07:12
@CarlSchwan
Copy link
Copy Markdown
Member Author

/backport stable 22

@CarlSchwan
Copy link
Copy Markdown
Member Author

/backport stable22

@CarlSchwan CarlSchwan merged commit ff684f3 into master Aug 17, 2021
@CarlSchwan CarlSchwan deleted the work/object-storage-compatibility branch August 17, 2021 07:31
@CarlSchwan
Copy link
Copy Markdown
Member Author

/backport stable22

@Pytal
Copy link
Copy Markdown
Member

Pytal commented Aug 17, 2021

/backport to stable22

@backportbot-nextcloud
Copy link
Copy Markdown

backportbot-nextcloud Bot commented Aug 17, 2021

The backport to stable22 failed. Please do this backport manually.

👉 #1631

@CarlSchwan
Copy link
Copy Markdown
Member Author

@Pytal I already created manual backport mr. Seems like I messed up the syntax for the backport bot

@artonge
Copy link
Copy Markdown
Contributor

artonge commented Sep 7, 2021

@CarlSchwan would it be possible to backport this PR to v21 ?

@artonge
Copy link
Copy Markdown
Contributor

artonge commented Sep 7, 2021

/backport to stable21

@artonge
Copy link
Copy Markdown
Contributor

artonge commented Sep 7, 2021

/backport to stable20

@backportbot-nextcloud
Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@PVince81
Copy link
Copy Markdown
Member

manual backport still required ?

@artonge
Copy link
Copy Markdown
Contributor

artonge commented Sep 13, 2021

Hmm, tried to do it manually but it seems that it has already been done:

So, no ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Items that are ready for releasing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants