This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Closed
Conversation
Not constructing the image in memory saves valuable resources * Pass around File or ISimpleFile objects * Use the FileDisplayResponse so we have all the fancy caching Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added
2. developing
oparoz
suggested changes
May 8, 2017
Member
oparoz
left a comment
oparoz
left a comment
There was a problem hiding this comment.
Some of the changes made on the PreviewController also need to be made on the PreviewApiController unfortunately as they behave slightly differently.
That's one reason a lot of the tests fail
Member
|
I guess also this needs to be moved to 13 |
Member
|
Unfortunately, yes. |
Member
|
Moved to 14. |
6 tasks
Member
|
Moved to 15 |
29 tasks
Member
|
The gallery app has been replaced by the beautiful new app: Please checkout if your Pull request is still necessary there, and in case create it there or raise an issue for others to copy the change from here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not constructing the image in memory saves valuable resources
TODO: