Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
LGTM. |
|
Hmmm... "You" have probably made changes to your test class again in server. Since there is no dev ML at NC, these sort of changes should be announced in the forums. |
Looking at @rullzer and @nickvergessen |
|
No, we fixed the test class to stay compatible |
|
Yes, we sorted it out in the end, but we just have to be careful with such changes as it's unpleasant for app devs to have to fight against problems which come out of nowhere and are out of their hands :) |
|
Well usually I see such things on my own apps first, so there is always an example how to fix it. ;) I try my best to keep that up and not let it happen again. |
Out of nowhere? That are private namespace classes - we have everywhere big warnings not to use them. 😉 |
|
Well Test\TestCase is an Exception |
See nextcloud/server#1948
cc @oparoz