Add setting section in the app developement tutorial#7178
Merged
CarlSchwan merged 1 commit intomasterfrom Oct 14, 2021
Merged
Conversation
CarlSchwan
force-pushed
the
work/dev_settings
branch
2 times, most recently
from
bb1bc9d to
1c248e5
Compare
kesselb
reviewed
Oct 11, 2021
|
|
||
| public function getAuthorizedAppConfig(): array { | ||
| return [ | ||
| // Allow list of regex that the user can modify with this setting. |
Contributor
There was a problem hiding this comment.
This was for apps/provisioning_api/lib/Controller/AppConfigController.php right?
ChristophWurst
approved these changes
Oct 12, 2021
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good. Personally I would prefer this to be on a dedicated page for app settings rather than within the tutorial as arguably most apps don't need settings pages and we will make the tutorial more complicated for beginners.
Fix #7158 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
work/dev_settings
branch
from
1c248e5 to
b83a86e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7158
Signed-off-by: Carl Schwan carl@carlschwan.eu