Add file extension "mjs" to list of translatable files#355
Merged
rakekniven merged 2 commits intomasterfrom Feb 17, 2022
Merged
Add file extension "mjs" to list of translatable files#355rakekniven merged 2 commits intomasterfrom
rakekniven merged 2 commits intomasterfrom
Conversation
Fixes #354 Should fix baimard/gestion#146 as well. Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
nickvergessen
approved these changes
Feb 17, 2022
Member
Author
|
Hello @nickvergessen , does this PR needs to be deployed somewhere after it has been merged? |
Member
|
Yes i guess so. |
Member
|
Deployed and triggered manually. |
Member
Author
|
No new strings from mjs as source files this morning. |
Member
Author
|
@nickvergessen This PR has been closed. But the strings from MJS files are still missing. |
This was referenced Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354
Should fix baimard/gestion#146 as well.
Signed-off-by: rakekniven 2069590+rakekniven@users.noreply.github.com