Skip to content

Build new translationtool.phar#339

Merged
nickvergessen merged 2 commits intomasterfrom
deploy/331
Jan 4, 2022
Merged

Build new translationtool.phar#339
nickvergessen merged 2 commits intomasterfrom
deploy/331

Conversation

@nickvergessen
Copy link
Copy Markdown
Member

Fix #331

@mgallien do you know how/where to deploy this? Is merging to master enough? Or does it need manual pulling somewhere?

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@mgallien
Copy link
Copy Markdown
Collaborator

mgallien commented Jan 3, 2022

going to try to remember what is needed
at least a new version of the docker image should be generated

@mgallien
Copy link
Copy Markdown
Collaborator

mgallien commented Jan 3, 2022

@nickvergessen from my understanding our scripts do not specify a tag when running the docker image to handle server translations (see https://github.com/nextcloud/docker-ci/blob/master/translations/transifexSync.php#L69)

@nickvergessen
Copy link
Copy Markdown
Member Author

Okay, so we merge and tag and it should be fine?

@mgallien
Copy link
Copy Markdown
Collaborator

mgallien commented Jan 3, 2022

Okay, so we merge and tag and it should be fine?

from my understanding yes
after you have pushed a tag, remember that you need to trigger the image build through a github action

@nickvergessen nickvergessen merged commit baec26c into master Jan 4, 2022
@nickvergessen nickvergessen deleted the deploy/331 branch January 4, 2022 15:44
@nickvergessen
Copy link
Copy Markdown
Member Author

Hopefully I did everything correct?
https://github.com/nextcloud/docker-ci/actions/runs/1654392708
I had no clue what to put in the fields.

@rakekniven
Copy link
Copy Markdown
Member

Will this improvement work for the whole Nextcloud org at GitHub or server repo only?

@nickvergessen
Copy link
Copy Markdown
Member Author

Should work for apps and seever since Monday

@rakekniven
Copy link
Copy Markdown
Member

There was one vue commit yesterday at polls and it has no comment.
Maybe it was bad timing.

@nickvergessen
Copy link
Copy Markdown
Member Author

Spreed was synced and doesn't have it either. Can you create me a screenshot where the translator hints show normally in transifex?

@rakekniven
Copy link
Copy Markdown
Member

rakekniven commented Jan 11, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy improvement for translation of vue files

4 participants