Skip to content

fix: Remove fully_qualified_strict_types again #16

Merged
nickvergessen merged 2 commits intomasterfrom
nickvergessen-patch-1
Feb 1, 2024
Merged

fix: Remove fully_qualified_strict_types again #16
nickvergessen merged 2 commits intomasterfrom
nickvergessen-patch-1

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 1, 2024

fully_qualified_strict_types => leading_backslash_in_global_namespace we want to use was only introduced with 3.46 PHP-CS-Fixer/PHP-CS-Fixer@0061223

@nickvergessen nickvergessen requested a review from come-nc February 1, 2024 13:36
@nickvergessen nickvergessen self-assigned this Feb 1, 2024
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 1, 2024

Broke the update in notifications, works after bumping cs-fixer as well:
https://github.com/nextcloud/notifications/pull/1807/files#diff-f37acfaa6b11f575a9a6f41a75fa73a61d0f8ebc2c9b8cddc215d8aca10e44f5L1132-R1132

come-nc
come-nc previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New minor release with changelog line?

come-nc
come-nc reviewed Feb 1, 2024
View reviewed changes
ChristophWurst
ChristophWurst previously approved these changes Feb 1, 2024
View reviewed changes
nickvergessen and others added 2 commits February 1, 2024 15:38
@nickvergessen
fix: Remove fully_qualified_strict_types again
51cf509 
There are currently too many issues for the rule on the project itself
#17
PHP-CS-Fixer/PHP-CS-Fixer#7719

Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@nickvergessen
fix(docs): Update old file name in readme
35fd40e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 1, 2024

As per #17 we remove the rule for now again instead

@nickvergessen nickvergessen changed the title Update required cs-fixer version fix: Remove fully_qualified_strict_types again Feb 1, 2024
@come-nc
Copy link
Contributor

come-nc commented Feb 1, 2024

We may still want to update php-cs-fixer?

@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 1, 2024

We may still want to update php-cs-fixer?

It's not required anymore, so I prefer to not break things :-X

@nickvergessen nickvergessen merged commit cf5f18d into master Feb 1, 2024
@delete-merged-branch delete-merged-branch bot deleted the nickvergessen-patch-1 branch February 1, 2024 14:54
@come-nc
Copy link
Contributor

come-nc commented Feb 1, 2024

We may still want to update php-cs-fixer?

It's not required anymore, so I prefer to not break things :-X

Yeah but then you’re not fixing things either

@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 1, 2024

Yeah but then you’re not fixing things either

No need to fix something that is not broken.

We can make a new version/branch with 2.0 requiring 8.0 and cs-fixer 3.48+ or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@come-nc come-nc come-nc approved these changes

@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees

@nickvergessen nickvergessen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @come-nc @ChristophWurst

Comments