Conversation
php-cs-fixer has a couple of peer dependencies. There is a chance that a php-cs-fixer dependency may conflict with our own dependencies. php-cs-fixer/shim is php-cs-fixer as compiled phar. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Member
|
The repos I touch all use https://packagist.org/packages/bamarni/composer-bin-plugin. Are there repos that use the cs fixer as direct (dev) dependency? |
Contributor
Author
ChristophWurst
approved these changes
May 30, 2023
nickvergessen
approved these changes
May 30, 2023
Member
nickvergessen
left a comment
There was a problem hiding this comment.
Thanks for diving into this. 🙇🏼♂️
So we need a new release after this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php-cs-fixer/shim is php-cs-fixer as compiled phar.
php-cs-fixer has a couple of peer dependencies. There is a chance that a php-cs-fixer dependency may conflict with our dependencies.
Before:
After: